Opened 9 years ago

Closed 9 years ago

#48 closed defect (fixed)

Instructions for running "real FTP access" test are unclear

Reported by: ssteiner Owned by: schwa
Priority: major Milestone:
Component: Library Version: 2.4.2
Keywords: tests docs Cc:

Description

_test_real_ftp.py Test for real FTP access.

This test writes some files and directories on the local client and the remote server. Thus, you may want to skip this test by pressing [Ctrl-C].

If the test should run, enter the login data for the remote server.

This is not clear -- enter the login data how and where?

Change History (4)

comment:1 Changed 9 years ago by schwa

Status: newassigned

Yes, that's not so great. Please look at function get_login_data near the top of _test_real_ftp.py and adapt it.

A longer-term approach might be to take the credentials from a file which is only readable by the user running the tests. Using environment variables for userid and password is dangerous because the environment of a user can be inspected by other users, so they're able to see the password.

At least the text output by _test_real_ftp.py should be fixed to tell to change get_login_data.

comment:2 Changed 9 years ago by ssteiner

There's always .netrc, we could just tell them to add an entry, and prompt for the server name to connect to.

comment:3 Changed 9 years ago by schwa

Milestone: 2.5

I did a workaround in changeset [ca06daa965b8]. I agree that there should be a cleaner solution.

comment:4 Changed 9 years ago by schwa

Resolution: fixed
Status: assignedclosed

I hope the workaround is good enough, so I close this bug for now. If someone strongly disagrees they may reopen the ticket. ;-)

Note: See TracTickets for help on using tickets.