Opened 4 weeks ago

Last modified 4 weeks ago

#135 new defect

test if_newer failing

Reported by: ftputiluser Owned by: schwa
Priority: minor Milestone:
Component: Library Version:
Keywords: Cc:

Description

in mock_ftplib.py, some file are set to Jan 19 2020, expecting in test to be in future

but this is not the case anymore... date should be placed at later date

Change History (2)

comment:1 Changed 4 weeks ago by schwa

Thanks for the heads up. The test code isn't written as carefully as the library code.

Meanwhile mock_ftplib.py has been removed in the repository because I'm using another mocking approach now (see ticket #98 and browser:test/scripted_session.py). Nevertheless, there could be similar problems in the new code. I guess I'll check the tests when I'm working on #134, which I need to finish before the release of ftputil 4.0.0. I use the word "need" because dealing with #134 means a backward-incompatible change and I don't want to release a version 5.0.0 shortly after 4.0.0. ;-)

Again, thank you. :-)

comment:2 Changed 4 weeks ago by schwa

I was just wondering why you would still use mock_ftplib.py and noticed that in the Mercurial repo browser the master bookmark is at January 2019 whereas the last commits on master are actually from the start of this year.

I pushed deliberately with -B master now and the repo view seems to be updated. I had assumed that the bookmark in the repo on the website would be updated if I had pushed the bookmark in the past.

Note: See TracTickets for help on using tickets.