Changeset 1824:f35237913b7d


Ignore:
Timestamp:
Jun 30, 2019, 5:41:17 PM (4 months ago)
Author:
Stefan Schwarzer <sschwarzer@…>
Branch:
default
rebase_source:
012ad72016d3a9155636d22911b554a63664946f
Message:
Add XXX comment on text file creation
File:
1 edited

Legend:

Unmodified
Added
Removed
  • ftputil/file.py

    r1723 r1824  
    8484        # `BufferedReader` or `BufferedWriter` object.
    8585        fobj = self._conn.makefile(makefile_mode)
     86        # XXX: I think this is only a leftover from the times of
     87        # Python 2 support. It would be more elegant to create text
     88        # file objects directly since Python 3's `socket.makefile`
     89        # supports a `mode` argument.
    8690        if not is_binary_mode:
    8791            fobj = io.TextIOWrapper(fobj, encoding=encoding,
Note: See TracChangeset for help on using the changeset viewer.