Changeset 1823:d8f5fdc5815b

Timestamp:

Jun 30, 2019, 4:40:26 PM (8 weeks ago)

Author:

Stefan Schwarzer <sschwarzer@…>

Branch:

default

Message:

Add TODO comment on future test revision

Add TODO comment on future test revision for binary/text modes.

File:

• test/test_file.py (modified) (1 diff)

test/test_file.py

@@ -42 +42 @@
 class TestFileOperations:
     """Test operations with file-like objects."""
+
+    # TODO: Revise these tests when done with the test infrastructure
+    # redesign. Most tests in this class seem to be from a time when
+    # there were was specific support for FTP "ASCII" transfers (i. e.
+    # with `TYPE A`, although `TYPE A` was actually never used, but the
+    # line ending conversions were done in ftputil). Meanwhile,
+    # there's no longer support for this ASCII mode in ftputil, but we
+    # have a distinction between binary and text mode, like in
+    # Python's built-in `open` function. I _think_ the support for
+    # binary and text mode is ok, but we should have new tests for
+    # both modes.
 
     def test_inaccessible_dir(self):