Changeset 1745:2402b8a75178
- Timestamp:
- Dec 29, 2018, 9:49:25 PM (2 years ago)
- Branch:
- default
- Children:
- 1746:72d797a82efe, 1762:d5ce348ec42f
- Files:
-
- 6 edited
Legend:
- Unmodified
- Added
- Removed
-
Makefile
r1740 r1745 26 26 PYTHONPATH=${PROJECT_DIR}:${TEST_DIR} 27 27 28 # TODOSome platforms call that script rst2html.py - allow both.28 # TODO: Some platforms call that script rst2html.py - allow both. 29 29 RST2HTML=rst2html 30 30 -
ftputil/file_transfer.py
r1718 r1745 12 12 13 13 14 # TODOThink a bit more about the API before making it public.14 # TODO: Think a bit more about the API before making it public. 15 15 # # Only `chunks` should be used by clients of the ftputil library. Any 16 16 # # other functionality is supposed to be used via `FTPHost` objects. -
ftputil/host.py
r1739 r1745 62 62 self._args = args 63 63 self._kwargs = kwargs 64 # XXXMaybe put the following in a `reset` method.64 # XXX: Maybe put the following in a `reset` method. 65 65 # The time shift setting shouldn't be reset though. 66 66 # Make a session according to these arguments. … … 142 142 there aren't any. 143 143 """ 144 # TODO: Currently timed-out child sessions aren't removed and144 # TODO: Currently timed-out child sessions aren't removed and 145 145 # may collect over time. In very busy or long running 146 146 # processes, this might slow down an application because the … … 694 694 raise ftputil.error.PermanentError("directory '{}' not empty". 695 695 format(path)) 696 # XXXHow does `rmd` work with links?696 # XXX: How does `rmd` work with links? 697 697 def command(self, path): 698 698 """Callback function.""" … … 817 817 self._session.rename(source, target) 818 818 819 # XXX One could argue to put this method into the `_Stat` class, but820 # I refrained from that because then `_Stat` would have to know821 # about `FTPHost`'s `_session` attribute and in turn about819 # XXX: One could argue to put this method into the `_Stat` class, 820 # but I refrained from that because then `_Stat` would have to 821 # know about `FTPHost`'s `_session` attribute and in turn about 822 822 # `_session`'s `dir` method. 823 823 def _dir(self, path): -
ftputil/stat.py
r1744 r1745 139 139 format(mode_string)) 140 140 st_mode = 0 141 # TODOAdd support for "S" and sticky bit ("t", "T").141 # TODO: Add support for "S" and sticky bit ("t", "T"). 142 142 for bit in mode_string[1:10]: 143 143 bit = (bit != "-") … … 274 274 # supposed (rounded) and the actual time shift. 275 275 # 276 # XXX The downside of this "correction" is that there is276 # XXX: The downside of this "correction" is that there is 277 277 # a one-minute time interval exactly one year ago that 278 278 # may cause that datetime to be recognized as the current … … 633 633 # Path was not found during the loop. 634 634 if _exception_for_missing_path: 635 # TODO Use FTP `LIST` command on the file to implicitly use636 # the usual status code of the server for missing files637 # (450 vs. 550).635 # TODO: Use FTP `LIST` command on the file to implicitly 636 # use the usual status code of the server for missing 637 # files (450 vs. 550). 638 638 raise ftputil.error.PermanentError( 639 639 "550 {}: no such file or directory".format(path)) -
ftputil/stat_cache.py
r1730 r1745 96 96 raise an exception. 97 97 """ 98 # XXX To be 100 % sure, this should be `host.sep`, but I don't99 # want to introduce a reference to the `FTPHost` object for100 # only that purpose.98 # XXX: To be 100 % sure, this should be `host.sep`, but I 99 # don't want to introduce a reference to the `FTPHost` object 100 # for only that purpose. 101 101 assert path.startswith("/"), ("{} must be an absolute path". 102 102 format(path)) … … 120 120 "entry for path {} has expired".format(path)) 121 121 else: 122 # XXX I don't know if this may raise a `CacheMissError` in123 # case of race conditions. I prefer robust code.122 # XXX: I don't know if this may raise a `CacheMissError` 123 # in case of race conditions. I prefer robust code. 124 124 try: 125 125 return self._cache[path] -
ftputil/sync.py
r1727 r1745 80 80 it's actually a file, raise a `SyncError`. 81 81 """ 82 # TODOHandle setting of target mtime according to source mtime82 # TODO: Handle setting of target mtime according to source mtime 83 83 # (beware of rootdir anomalies; try to handle them as well). 84 84 #print("Making", target_dir) … … 93 93 94 94 def _sync_file(self, source_file, target_file): 95 # XXXThis duplicates code from `FTPHost._copyfileobj`. Maybe95 # XXX: This duplicates code from `FTPHost._copyfileobj`. Maybe 96 96 # implement the upload and download methods in terms of 97 97 # `_sync_file`, or maybe not? 98 # TODOHandle `IOError`s99 # TODOHandle conditional copy100 # TODOHandle setting of target mtime according to source mtime98 # TODO: Handle `IOError`s 99 # TODO: Handle conditional copy 100 # TODO: Handle setting of target mtime according to source mtime 101 101 # (beware of rootdir anomalies; try to handle them as well). 102 102 #print("Syncing", source_file, "->", target_file) … … 153 153 This method handles both directory trees and single files. 154 154 """ 155 # TODO Handle making of missing intermediate directories155 # TODO: Handle making of missing intermediate directories. 156 156 source_path = self._source.path.abspath(source_path) 157 157 target_path = self._target.path.abspath(target_path)
Note: See TracChangeset
for help on using the changeset viewer.