Changeset 1824:f35237913b7d for ftputil/file.py

Timestamp:

Jun 30, 2019, 5:41:17 PM (20 months ago)

Author:

Stefan Schwarzer <sschwarzer@…>

Branch:

default

rebase_source:

012ad72016d3a9155636d22911b554a63664946f

Message:

Add XXX comment on text file creation

File:

• ftputil/file.py (modified) (1 diff)

ftputil/file.py

@@ -84 +84 @@
         # `BufferedReader` or `BufferedWriter` object.
         fobj = self._conn.makefile(makefile_mode)
+        # XXX: I think this is only a leftover from the times of
+        # Python 2 support. It would be more elegant to create text
+        # file objects directly since Python 3's `socket.makefile`
+        # supports a `mode` argument.
         if not is_binary_mode:
             fobj = io.TextIOWrapper(fobj, encoding=encoding,