Changeset 1722:2500d9b34941 for find_invalid_code.py

Timestamp:

Dec 26, 2018, 7:49:04 PM (2 years ago)

Author:

Stefan Schwarzer <sschwarzer@…>

Branch:

default

Message:

Remove obsolete features

Remove detection of "invalid" features that are either ancient or no
longer invalid. "Ancient" is the use of `xreadlines`; this should
hardly be used anymore nowadays. "No longer invalid" are detections of
byte strings starting with quotes. In Python 3, these are unicode
strings, and it's unlikely that code _deliberately_ uses actual byte
strings starting with `b`.

File:

• find_invalid_code.py (modified) (1 diff)

find_invalid_code.py

@@ -56 +56 @@
                  r"\bftp_stat\b"),
   InvalidFeature("Possible use(s) of FTPHost.file",
-                 r"{0}\.file\(".format(HOST_REGEX)),
-  InvalidFeature("Possible use(s) of FTPHost.open with text mode",
-                 r"{0}\.open\(.*[\"'](r|w)t?[\"']".format(HOST_REGEX)),
-  InvalidFeature("Possible use(s) of byte string in ignores_line",
-                 r"\bdef ignores_line\("),
-  InvalidFeature("Possible use(s) of byte string in parse_line",
-                 r"\bdef parse_line\("),
-  InvalidFeature("Possible use(s) download with text mode",
-                 r"{0}\.download(_if_newer)?\(".format(HOST_REGEX)),
-  InvalidFeature("Possible use(s) upload with text mode",
-                 r"{0}\.upload(_if_newer)?\(".format(HOST_REGEX)),
-  InvalidFeature("Possible use(s) of xreadline method of FTP file objects",
-                 r"\.\s*?xreadlines\b"),
+                 r"{0}\.file\(".format(HOST_REGEX))
 ]