{5} Assigned, Active Tickets by Owner (Full Description) (7 matches)

I think it extremely useful for ftp admins, but neither ftplib nor ftputil support it.

Of course, download from one host then upload to another is a workaround, but it's really not a efficient way.

Roger Demetrescu suggests in this mail to add support for Python's with statement, introduced in Python 2.5.

The example Roger gives is about using the with statement on FTPHost objects, but I think even more it should also be applied to FTPFile objects.

Stefan

Despite there are many syncing/mirroring scripts for FTP servers out there, it might be worthwhile to bundle such a script with ftputil to:

• provide a working example of ftputil code
• learn more about ftputil usage and by that find out about functionality that should be added
• serve as a benchmark for measurements before and after implementation regarding issue #3

I classify this issue as "minor" because the mirror script isn't that important for the functioning of ftputil.

For writing binary files on MVS I needed to send some additional commands to the ftp server. The following codes shows an example:

file = ftputil.FTPHost(host, user, password).file("/"+name, "wb",
                                            addcmds=("SITE BLKSIZE=0",
                                                     "SITE RECFMT=FB",
                                                     "SITE LRECL=%d" % length ))

Btw. this example shows a workaround for track # 26 by adding a "/" to the filename.

I applied the following patches to achieve this behaviour:

--- ftputil.py 
+++ ../ftputil-2.2.3/ftputil.py 
@@ -191,7 +191,7 @@
         # be explicit
         return None
 
-    def file(self, path, mode='r', **args):
+    def file(self, path, mode='r'):
         """
         Return an open file(-like) object which is associated with
         this `FTPHost` object.
@@ -220,7 +220,7 @@
             #  raise an `IOError`, not an `OSError`
             raise ftp_error.FTPIOError("remote directory '%s' doesn't exist "
                   "or has insufficient access rights" % effective_dir)
-        host._file._open(effective_file, mode, **args)
+        host._file._open(effective_file, mode)
         if 'w' in mode:
             self.stat_cache.invalidate(effective_path)
         return host._file

--- ftp_file.py 
+++ ../ftputil-2.2.3/ftp_file.py 
@@ -87,15 +87,8 @@
         # the file is closed yet
         self.closed = True
 
-    def _open(self, path, mode, **args):
-        """ Open the remote file with given path name and mode
-            and possibly additional arguments.
-
-            Possible keys for args:
-            addcmds     List of additional ftp-commands to send
-                        before the STOR/RETR command (e.g. to set
-                        file information on mvs)
-        """
+    def _open(self, path, mode):
+        """Open the remote file with given path name and mode."""
         # check mode
         if 'a' in mode:
             raise ftp_error.FTPIOError("append mode not supported")
@@ -108,8 +101,6 @@
         transfer_type = ('A', 'I')[self._bin_mode]
         command = 'TYPE %s' % transfer_type
         ftp_error._try_with_ioerror(self._session.voidcmd, command)
-        for command in args.get("addcmds", []) :
-            ftp_error._try_with_ioerror(self._session.voidcmd, command)
         # make transfer command
         command_type = ('STOR', 'RETR')[self._read_mode]
         command = '%s %s' % (command_type, path)

Hopefully, you like this patch and incorporate it into ftputil.

Regards, Axel